-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PRIMAVERA Eady Growth Rate diagnostic #1285
Conversation
Co-Authored-By: Bouwe Andela <[email protected]>
Some of the models in the recipe require fixes, do I need to open an issue in the core? Or can I directly open a pull request? I already had them collected in a branch. |
Co-authored-by: Stef Smeets <[email protected]>
Once you're done with all the technical work, I think it might be nice ask them to comment (and approve) here, to make it a bit more visible. It would be great if they could try out the new scientific review checklist. |
Hello, The description looks fine. I think we could complete it with a reference:
The plots look fine, but we could adapt the color scale for values between 0 and 1.1 or so, to see better the signal over the Atlantic. But this is just a suggestion. I would approve the merge of this recipe. |
Thank you for the comments @emchamarro! Added the suggestions. |
@jvegasbsc can you take a look at this, I am not sure why some tests suddenly do not pass. Other than that I would say that everything is ready now? |
Merge master, I think you need #2022 |
It's already up do date. Do I need to do anything else to get this approved? |
I got the same issues in other branches, so don't care |
Description
Recipe and diagnostic script to compute the Eady Growth Rate (PRIMAVERA)
Before you get started
Checklist
It is the responsibility of the author to make sure the PR is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
pre-commit
oryamllint
checksNew or updated recipe/diagnostic:
[ ] 🛠 New dependencies are added to the project requirements@esmvalbot
or some other machine without modificationTo help with the number pull requests: